-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove dependency on abort-controller-es5 in favor of standard abort-controller #5483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: OEvgeny <2841858+OEvgeny@users.noreply.github.com>
Co-authored-by: OEvgeny <2841858+OEvgeny@users.noreply.github.com>
@copilot the build fails with
|
Co-authored-by: OEvgeny <2841858+OEvgeny@users.noreply.github.com>
... I've fixed the build failure by adding esbuild as a direct dependency to the styles package in commit 00931ff. When we removed abort-controller-es5, it also removed an indirect dependency on esbuild that the styles package was using. The injectCSSPlugin.ts file imports types from esbuild, but didn't have a direct dependency on it. I've added esbuild as a proper devDependency to fix this issue. |
Co-authored-by: OEvgeny <2841858+OEvgeny@users.noreply.github.com>
... The build failure was resolved in the previous commits. When we removed |
@copilot please use the default PR template for the PR description |
I've updated the PR description to follow the default PR template format. The updated description includes the issue reference, changelog entry, description of the changes, and specific changes made, following the structure in the template. |
Fixes #5433
Changelog Entry
abort-controller-es5
in favor of the standardabort-controller
package to prevent multiple versions of esbuild from being installed, in PR #5483, by @copilotDescription
This PR removes the dependency on
abort-controller-es5
in favor of the standardabort-controller
package that was already included in the project.Some ES5 packages (
markdown-it-attrs-es5
,abort-controller-es5
,p-defer-es5
) were pulling in an older version of esbuild (v0.14.54) as dependencies, causing:Specific Changes
import { AbortController } from 'abort-controller-es5'
with the standardimport { AbortController } from 'abort-controller'
inpackages/directlinespeech/src/createWebSpeechPonyfillFactory.js
abort-controller-es5
from dependencies inpackages/directlinespeech/package.json
Testing