-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Architecture] Move suggested actions to React context #5490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
compulim
wants to merge
39
commits into
microsoft:main
Choose a base branch
from
compulim:feat-state-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
reviewed
May 30, 2025
...ges/component/src/providers/ClipboardWritePermissionWithStable/private/useStableStateHook.ts
Outdated
Show resolved
Hide resolved
OEvgeny
reviewed
May 30, 2025
...ges/component/src/providers/ClipboardWritePermissionWithStable/private/useStableStateHook.ts
Outdated
Show resolved
Hide resolved
OEvgeny
reviewed
May 30, 2025
...ges/component/src/providers/ClipboardWritePermissionWithStable/private/useStableStateHook.ts
Outdated
Show resolved
Hide resolved
afc7def
to
f01d1cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
One issue we know for long... "our React context object is too big, one tiny change in the context object means everyone subscribing to it will need to change." This kind of problem plague React context, Redux and is everywhere inside/outside of Web Chat.
For the last few years, when we build features, we are building smaller context object than using the uber one. Now we are looking into how to make our legacy context objects update less frequent.
We will try a few approaches, currently 2 approaches we are trying:
p.s. we also shop around and thought about Redux reselect approach... and in React sense, it will be HOC +
memo()
. But preliminary thinking tell us it doesn't sound it will improve perf better than the other 2 approaches.Design
Specific Changes
react-context
packagecreateBitContext
for quickly creating a context with a single stateuseStableStateHook
for recreating auseState
-hook via a stable factory functionsuggestedActions
reducer to React contextclearSuggestedActionsOnPostActivity
saga to React contextsendBoxAttachments
andsendBoxValue
reducer to React contextuseSendBoxAttachments
anduseSendBoxValue
hookssetRawState
and<ReduxActionSinkComposer>
to facilitate replicationCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)