WaitForExitAsync: Handle timeout exception when timeout parameter set #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brdeyo
requested changes
May 12, 2025
| @@ -365,6 +365,10 @@ public virtual async Task WaitForExitAsync(CancellationToken cancellationToken, | |||
| { | |||
| // Expected whenever the CancellationToken receives a cancellation request. | |||
| } | |||
| catch (TimeoutException) when (timeout != null) | |||
There was a problem hiding this comment.
This should NOT be swallowed here. There are upstream cases where the caller of this logic needs to know if the process did not actually complete within the timeout allotted. TimeoutException should be handled in the calling locations, not the core method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.