feat(react-17,18-tests): bootstrap r17,r18 integration tests #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
force-pushed
the
integration/react/17
branch
11 times, most recently
from
c798509 to
e1716f5
Compare
Hotell
changed the title
Hotell
force-pushed
the
integration/react/17
branch
6 times, most recently
from
6749896 to
91eadd6
Compare
Hotell
changed the title
This was referenced May 21, 2025
Hotell
force-pushed
the
integration/react/17
branch
from
91eadd6 to
4215eca
Compare
Hotell
commented
Jun 24, 2025
| * @param {string} code The code to transform | ||
| * @returns {string} The transformed code | ||
| */ | ||
| function transformRenderHookUsage(code) { |
There was a problem hiding this comment.
necessary to transform test sources to use react 17 related valid apis.
in case of react 17 and RTL with RTL react-hooks we need to transform import {renderHooks} from '@testing-library/react' to import {renderHooks} from '@testing-library/react-hooks' after transpilation to vanilla js happened.
dmytrokirpa
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similarly to microsoft/fluentui#34247 bootstraps integration test agains react v17 and r18 (to get proper type checks data set, which is currently missing)
NOTE: already exposes some issues with React 17 https://github.com/microsoft/fluentui-contrib/actions/runs/15853543512/job/44692987043?pr=391
to make this work, we introduce additional features ( will be done as separate PRs for granularity )