-
Notifications
You must be signed in to change notification settings - Fork 44
chore: setup workspaces in monorepo #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -60,14 +60,15 @@ | |||
"@storybook/preview-api": "7.6.20", | |||
"@storybook/react-webpack5": "7.6.20", | |||
"@storybook/test-runner": "0.14.0", | |||
"@storybook/testing-library": "^0.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused - added RTL/DOM old dupe
@@ -6,15 +6,15 @@ | |||
"generators": "./generators.json", | |||
"executors": "./executors.json", | |||
"dependencies": { | |||
"@nx/devkit": "^20.2.2", | |||
"@nx/devkit": "^20", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simplified dep resolution to mitigate churn when migrating to new nx versions in repo
@@ -12,7 +12,7 @@ | |||
"type-check": "nx affected --target=type-check", | |||
"preinstall": "node ./tools/scripts/preinstall.mjs", | |||
"postinstall": "patch-package", | |||
"dedupe": "npx yarn-deduplicate --strategy fewer" | |||
"dedupe": "npx yarn-deduplicate --strategy highest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will dedupe to highest possible semver range -> thus all packages in our repo are bumped as part of this PR
To follow other repos setup and recent guidance of nx team, we are enabling
workspaces
for contrib as well.This adds 2 additional changes:
@types/react@18
as source of truth without need of resolution config, once integration tests are implemented for lower react versions )Needed for
#391