Fix for XFSTest failing to build on older linux distros #3848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix for xfstesting.py, missing tab in test list is causing xfstest for SMB to fail.
Update xfstesting.py to account for missing tab in test list
add fixes for legacy Distros that are not able to build newer release of XFStest. In this case we fall back to last known Tag that can build on the respective distros without requirement of additional or "out of band" packages from non-official repos.
squirrelsc
reviewed
Jun 10, 2025
squirrelsc
reviewed
Jun 10, 2025
squirrelsc
reviewed
Jun 16, 2025
| return "default" | ||
| os_info = self.node.os.information | ||
| full_version = getattr(os_info, 'full_version', '') | ||
| major = getattr(os_info.version, 'major', 0) if hasattr(os_info, 'version') else 0 |
There was a problem hiding this comment.
@LiliDeng can you work with @shekharsorot to use the right pattern of os version comparison?
There was a problem hiding this comment.
@squirrelsc do you mean the way used like here ?
There was a problem hiding this comment.
Yes, mostly. But the following should be sufficient. Using < can handle temporary test versions (like Ubuntu) and minor version upgrads.
if isinstance(node.os, Redhat) and full_version < "7.1":
pass
elif isinstance(node.os, Redhat) and full_version < "7.2":
pass
else:
# newer versions
pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a key issue where any XFStest based cases are failing due to build compilation errors when using the latest branch of code from repo "https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git"
Upon investigation we found major changes being done to the code base in January of 2025., which caused build failures on system with glibc-devel < 2.23 deployed.
To work around this, a table has been added to the tool to specifically look for azure supported Linux Distros that were failing XFStest build and specified a last known release tag that was known to build without any issues.
This approach also allows us to add additional distros and version ID's in the future as needed and lock them to specific XFStest release tags.