Allow user passed MTUs for ntttcp network perf tests. #3857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables users to pass custom MTU values for Ntttcp network performance tests.
- Updated test functions in networkperf.py to accept an additional variables dictionary parameter.
- Modified perf_ntttcp in common.py to extract and apply the MTU from the provided variables.
- Updated Ntttcp performance message creation and dataclasses in ntttcp.py and messages.py to include client and server MTU fields.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| microsoft/testsuites/performance/networkperf.py | Added variables parameter to test case functions for Ntttcp performance testing. |
| microsoft/testsuites/performance/common.py | Introduced MTU extraction from variables and applied MTU settings for default and sriov NICs. |
| lisa/tools/ntttcp.py | Updated performance message functions to include client and server MTU parameters. |
| lisa/messages.py | Added MTU fields to the network performance message dataclasses. |
|
@LiliDeng please let me know if anything more needs to be done on this PR. |
|
Please hold off on this change for now. We're currently adding a unified message for ntttcp. Once that's merged, please add the new metrics to the unified message. |
SRIKKANTH
force-pushed
the
smyakam/custom_mtu_netperf/06_12_2025
branch
from
0918e8d to
7783b9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a need for testing network perf with different MTU sizes.
This change enables it.