Fix verify_ifcfg_eth0 for fedora 39 & above #3877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This testcase failes for the latest fedora 42. For Fedora 39 and above, fedora uses NetworkManager for the network management. The legacy /etc/sysconfig/network-scripts/ directory and ifcg-* files are deprecated. Tested with azure and the testcase is passing. Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the verify_ifcfg_eth0 method to support Fedora 39+ by using NetworkManager (nmcli) instead of legacy ifcfg files.
- Introduces branch for Fedora ≥39 to assert
autoconnectand DHCP usage vianmcli - Retains existing ifcfg-eth0 file check for Fedora <39
Comments suppressed due to low confidence (1)
microsoft/testsuites/core/azure_image_standard.py:473
- [nitpick] Add or update integration/end-to-end tests to cover the new
nmcli–based branch for Fedora 39+ so that these assertions are validated in CI.
# Check if the autoconnect is enabled for eth0
LiliDeng
approved these changes
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This testcase failes for the latest fedora 42.
For Fedora 39 and above, fedora uses NetworkManager for the network management. The legacy /etc/sysconfig/network-scripts/ directory and ifcg-* files are deprecated. Tested with azure and the testcase is passing.