Skip to content

Commit bc175f1

Browse files
authored
ci(macos): re-enable smoke test (#2468)
Also removed the x86 build step that hasn't built for x86 ever since we moved to ARM64 runners.
1 parent 354c3a0 commit bc175f1

File tree

2 files changed

+4
-19
lines changed

2 files changed

+4
-19
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ jobs:
373373
with:
374374
project-directory: macos
375375
working-directory: example
376-
- name: Build x86
376+
- name: Build
377377
if: ${{ steps.affected.outputs.macos != '' }}
378378
run: |
379379
../scripts/build/xcodebuild.sh macos/Example.xcworkspace build-for-testing
@@ -384,27 +384,10 @@ jobs:
384384
node --test test/config.test.mjs
385385
working-directory: example
386386
- name: Test
387-
# Temporarily disabled due to random failures
388-
if: false # ${{ steps.affected.outputs.macos != '' && github.event_name != 'schedule' }}
387+
if: ${{ steps.affected.outputs.macos != '' && github.event_name != 'schedule' }}
389388
run: |
390389
../scripts/build/xcodebuild.sh macos/Example.xcworkspace test-without-building
391390
working-directory: example
392-
- name: Prepare for arm64 build
393-
if: ${{ steps.affected.outputs.macos != '' }}
394-
run: |
395-
rm -fr macos/build
396-
working-directory: example
397-
- name: Install Pods
398-
if: ${{ steps.affected.outputs.macos != '' }}
399-
uses: ./.github/actions/cocoapods
400-
with:
401-
project-directory: macos
402-
working-directory: example
403-
- name: Build arm64
404-
if: ${{ steps.affected.outputs.macos != '' }}
405-
run: |
406-
../scripts/build/xcodebuild.sh macos/Example.xcworkspace build ARCHS=arm64
407-
working-directory: example
408391
timeout-minutes: 60
409392
macos-template:
410393
name: "macOS [template]"

example/ios/ExampleTests/DevSupportTests.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ - (void)testDevSupportIsLinked
1212
XCTAssertNotNil(ReactAppDidFinishLaunchingNotification);
1313
XCTAssertNotNil(ReactAppWillInitializeReactNativeNotification);
1414
XCTAssertNotNil(ReactAppDidInitializeReactNativeNotification);
15+
XCTAssertNotNil(ReactAppRuntimeReadyNotification);
16+
XCTAssertNotNil(ReactAppDidRegisterAppsNotification);
1517
XCTAssertNotNil(ReactAppSceneDidOpenURLNotification);
1618
}
1719

0 commit comments

Comments
 (0)