Update _git.py - added param to initialize_git_connection fn #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added initializationStrategy strategy parameter. Used when content exists in the workspace prior to calling initialize connection
m-kovalsky
requested changes
Feb 19, 2025
| @@ -276,6 +276,11 @@ def initialize_git_connection(workspace: Optional[str | UUID] = None) -> str: | |||
| The Fabric workspace name or ID. | |||
| Defaults to None which resolves to the workspace of the attached lakehouse | |||
| or if no lakehouse attached, resolves to the workspace of the notebook. | |||
| initialization_strategy : str | |||
There was a problem hiding this comment.
initialization_strategy : str, default='None'
| @@ -285,8 +290,14 @@ def initialize_git_connection(workspace: Optional[str | UUID] = None) -> str: | |||
|
|
|||
| (workspace_name, workspace_id) = resolve_workspace_name_and_id(workspace) | |||
|
|
|||
There was a problem hiding this comment.
add a check that the initialization_strategy is one of the 3 valid options. raise ValueError if it's not in those 3 options. This is just to make better error messages.
There was a problem hiding this comment.
Just a helpful note for @hurtn: You can look at how conflict_resolution_policy is validated in the update_from_git function within the same file. If you want to do it consistent in the same style and so on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added initializationStrategy strategy parameter. Used when content exists in the workspace prior to calling initialize connection