-
Notifications
You must be signed in to change notification settings - Fork 124
Added ability to target all Fabric data store types with create_shortcut_onelake #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…the create_shortcut_onelake function.
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. I made the updates, let me know if you think it needs anything else. Cheers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment for making code cleaner
Updated. I also made a similar change resolving the name and id of the destination lakehouse using the same |
Kept enhanced create_shortcut_onelake functionality that supports any Fabric data store type
@m-kovalsky I think this is ready for merge, but please let me know if there's anything else I need to change. |
Initially the
create_shortcut_onelake
function only allowed targeting a Lakehouse as a source. However, the APIs being used to create shortcuts can target anyitemId
.This PR includes updates to support creating shortcuts to any kind of Onelake data store item type; Lakehouse, Warehouse, MirroredDatabase, KQLDatabase, and SQLDatabase.
Note: The parameter structure of the function had to change slightly, including names of parameters and a new parameter for the data store type. This will break existing implementations using the original parameter structure of the
create_shortcut_onelake
function.