Skip to content

Conversation

@m-kovalsky
Copy link
Collaborator

No description provided.

@a-holm
Copy link

a-holm commented Mar 30, 2025

LGTM! This PR adds a useful deploy_report function, which looks like a great addition for managing report lifecycles. The refactoring of clone_report to use standardized helpers and support UUIDs is also a good improvement.

A couple of minor points to make it easier for the people who review PRs here:

  1. Consider adding a brief description to the PR explaining the motivation and summarizing the changes.
  2. In _report_functions.py, the docstring for clone_report could explicitly mention that it will not overwrite an existing report and will issue a warning instead. This clarifies the intended behavior compared to deploy_report.

Overall, nice work!

@m-kovalsky
Copy link
Collaborator Author

@a-holm I don't think we need this anymore as I created a generic copy_item function.

@m-kovalsky m-kovalsky closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants