Skip to content

Add nullable colors to Settings UI #9189

Closed
@carlos-zamora

Description

@carlos-zamora

Description of the new feature/enhancement

The following settings are missing from the Profile > Appearance page in the Settings UI:

  • tabColor
  • foreground
  • background
  • selectionBackground
  • cursorColor

This is because the color picker has no way to select "I don't have a color".

Proposed technical implementation details (optional)

  • Introduce a new control called "nullable color picker" containing...
    • a color picker
    • a checkbox (or toggle button) to inherit from the color scheme
    • (maybe) a dependency property to bind the color from the settings model to the control
  • use that new control in the Profile > Appearance page under a new "Colors" grouping

A minor design is needed for this. Particularly, we need to think about how this should be represented along with inheritance (SettingContainer). We want to make sure we don't confuse users with "inherit value from color scheme" and "inherit value from base layer", for example.

Metadata

Metadata

Assignees

Labels

Area-SettingsUIAnything specific to the SUIIssue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions