fix assumptions about how fd_prestat_get may be called #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
fd_prestat_get
does not appears to handle the following cases properly:For testing, I used the
./wasm-wasi/example
project and modified thehello.c
andextension.ts
:I modified the call to
createProcess
inextension.ts
to add an additional preopen directory:Before:
After:
The new output matches exactly what I got from wasmtime with
wasmtime run --dir=.::/foo --dir=.::/bar hello.wasm
.