Block mouse interaction while breadcrumbs/selectboxcustom dropdown is visible

[jeanp413]

Used the same approach as in contextMenuHandler to block mouse events

This PR fixes #113675

[jrieken]

Hm.... not a big fan. Breadcrumb pickers should close when resizing parts in the workbench IMO

[jeanp413]

Is there a way to detect that something is being resized so I can hide the breadcrumb picker?

Another option would be something like this (which doesn't look nice either)

const mouseDownListener = dom.addDisposableListener(window, dom.EventType.MOUSE_DOWN, e => {
	// // #113675 This mouse event is outside the breadcrumb so it counts as a focus out
	if (!dom.isAncestor(e.target as HTMLElement, this._widget.domNode) && !dom.isAncestor(e.target as HTMLElement, parent)) {
		this._contextViewService.hideContextView(this);
	}
});

Another one is removing this line that just calls e.preventDefault() underneath in the sash mousedown event handler. Doing so will transfer focus to the body and trigger the focusTracker onDidBlur event. Not sure if something else is relaying on this current behavior but it looks safe

vscode/src/vs/base/browser/ui/sash/sash.ts

Line 213 in 699d736

EventHelper.stop(e, false);

[jrieken]

Is there a way to detect that something is being resized so I can hide the breadcrumb picker?

That's the question. @sbatten should know

[sbatten]

It's not exactly what you want but its the only existing option I can think of, but if you can listen to the IWorkbenchLayoutService.onLayout event, once a resize happens, you could dismiss the dropdown.

However, I prefer the functionality of your initial PR more because:

• We got the behavior from macOS for the context menus and it proves to be quite nice
• Looking to Xcode's breadcrumbs shows that macOS also uses this technique so this would be consistent

[jeanp413]

@jrieken what do you think, should I still give it a try with IWorkbenchLayoutService.onLayout? or is the current implementation good enough as sbatten pointed out

[sbatten]

@jeanp413 should this behavior be on the custom select box? e.g. the terminal selector box suffers the same behavior

[jeanp413]

@sbatten yes, you can see it in the second gif I uploaded in the linked issue #113675

[sbatten]

@jeanp413 ah I see, I missed in the PR that the breadcrumbs control was doing something special so you have to handle it in both places.

[vivodi]

Is this still relevant?