Skip to content

Allow snippets' final placeholder ($0) to have choices #152187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

babakks
Copy link
Contributor

@babakks babakks commented Jun 15, 2022

This PR fixes #150745

⚠️ As already mentioned in the original issue, this fix is in conflict with an old issue, #31599.

babakks added 3 commits June 15, 2022 12:25
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
@babakks
Copy link
Contributor Author

babakks commented Jun 15, 2022

@jrieken Could you please review this?

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SnippetString.appendChoice() with placeholder=0 inserts snippet marked into the editor
2 participants