Skip to content

fix #158606 #159310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix #158606 #159310

wants to merge 2 commits into from

Conversation

Kalmaegi
Copy link
Contributor

No description provided.

@lszomoru lszomoru removed their assignment Aug 29, 2022
@rebornix rebornix assigned daviddossett and unassigned rebornix Oct 10, 2022
daviddossett
daviddossett requested changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@daviddossett daviddossett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for ths PR, @weartist. It looks like the input is actually 25px, not 26px. The elements surrounding it read as 26 for reasons I still can't figure out. But it's clear just looking at it:

Button at 26px

CleanShot 2022-10-10 at 15 54 42@2x

Button at 25px

CleanShot 2022-10-10 at 15 54 55@2x

@daviddossett daviddossett mentioned this pull request Oct 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddossett daviddossett daviddossett requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@daviddossett daviddossett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kalmaegi @daviddossett @rebornix @lszomoru @vscodenpa