fixes #168895 #169034
fixes #168895 #169034
Conversation
sbatten
requested review from
alexr00 and
jrieken
and removed request for
alexr00
|
I don't believe that I need to review this |
| this._actionHoverDelegate = { | ||
| placement: 'element', | ||
| showHover: (options: IHoverDelegateOptions) => { | ||
| options.hoverPosition = HoverPosition.ABOVE; |
There was a problem hiding this comment.
Can we use below instead so that we mimic OS tooltips better?
There was a problem hiding this comment.
The reason I chose ABOVE is because while native is below, its also slightly offset to account for the mouse position. Our hover service does seem to do this. This is why I went with above and with a beak.
There was a problem hiding this comment.
If you still prefer BOTTOM, we should improve the service to avoid the cursor.
There was a problem hiding this comment.
Oh, I forgot that the service does do this if you use mouse placement, but not if you choose element placement. Choosing mouse placement, the hover does not show for me, but I did not debug yet
There was a problem hiding this comment.
I'm still not sure what's going on with the mouse placement, but in the title bar we already show beak/element placement for action icons, so I think we should be consistent. We do below in the title bar because there is no above option, but we have a little more space there. Let me know what you think with all this info in mind.
There was a problem hiding this comment.
I would still put it below. We show the tree item hovers below, it would be inconsistent to show the action hovers above.
|
Is this still relevant? |
fixes #168895