Skip to content

Check nextEmbedded: '@pop' in action cases (issue#172061) #172193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

dmitriypereverza
Copy link

Monarch don't check nextEmbedded: '@pop' in action cases.

You can find out in advance that the exit from the embedded state exists in the compileAction function, and then just use this knowledge in the lexer.

Related issue: #172061

@dmitriypereverza
Copy link
Author

@microsoft-github-policy-service agree

@alexdima alexdima self-requested a review February 17, 2023 12:50
@alexdima alexdima added this to the March 2023 milestone Feb 22, 2023
@alexdima alexdima modified the milestones: March 2023, April 2023 Mar 23, 2023
@alexdima alexdima modified the milestones: April 2023, May 2023 Apr 26, 2023
@alexdima alexdima modified the milestones: May 2023, June 2023 May 31, 2023
@alexr00 alexr00 modified the milestones: June 2023, July 2023 Jun 27, 2023
@alexdima alexdima modified the milestones: July 2023, August 2023 Jul 26, 2023
@alexdima alexdima modified the milestones: August 2023, September 2023 Aug 31, 2023
@alexdima alexdima modified the milestones: September 2023, October 2023 Sep 29, 2023
@alexdima alexdima removed this from the October 2023 milestone Oct 27, 2023
@alexdima alexdima added this to the November 2023 milestone Oct 27, 2023
@alexdima alexdima modified the milestones: November 2023, December 2023 Nov 30, 2023
@aiday-mar aiday-mar modified the milestones: December / January 2024, February 2024 Jan 24, 2024
@alexdima alexdima modified the milestones: February 2024, March 2024 Feb 23, 2024
@alexdima alexdima modified the milestones: March 2024, On Deck Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants