Explore using CSS highlighting API for HighlightedLabel #175941
Draft
+107
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
force-pushed
the
substantial-basilisk
branch
from
22751f6 to
1fcd24a
Compare
ffiori
reviewed
Apr 2, 2025
| @@ -93,48 +105,80 @@ export class HighlightedLabel extends Disposable { | |||
| this.render(); | |||
| } | |||
|
|
|||
| private renderedText?: string; | |||
| private currentHighlightRanges: StaticRange[] = []; | |||
There was a problem hiding this comment.
Is this variable redundant with labelHighlights? If it contains the exact same set of ranges, then you could get rid of this variable and then clearHighlights() can be just defined as labelHighlights.clear()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #175938