Skip to content

Allow display:inline-block on spans style #180498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yoavbls
Copy link

@yoavbls yoavbls commented Apr 21, 2023

Solves #180496

@gjsjohnmurray
Copy link
Contributor

Pinging @mjbvz who might have an opinion about this change.

@lszomoru lszomoru assigned mjbvz and unassigned lszomoru Apr 25, 2023
@yoavbls
Copy link
Author

yoavbls commented Mar 1, 2024

@mjbvz Hey Matt,
I'm sorry I'm pinging you about it, but almost a year has passed, and I would be pleased if you could take a look at it and provide some clarification on the desired solution 🙏🏼

@aminya
Copy link
Contributor

aminya commented May 31, 2024

This oneliner fixes the only missing feature of ts-pretty-errors. Could someone take a look? Looks like one year should have been enough time for reviewing this simple fix.

@xenostar
Copy link

xenostar commented Sep 9, 2024

Hello @mjbvz and @gjsjohnmurray. It has been nearly 1.5 years since this PR was opened. Are there any further reservations about merging this in? This enables a fix for #180496, which will enable a massive developer experience improvement for the Pretty TS Errors plugin.

What are the steps we can take to get this prioritized and possibly merged? This would enable a huge improvement to the DX for nearly one million developer using this plugin.

@AndreMaz
Copy link

Any chance of merging this PR @mjbvz ?

@alanmoyano
Copy link

Hello! @mjbvz could you please check this out? This would be awesome for empowering extension developers.

@mbtools
Copy link

mbtools commented Mar 23, 2025

There's now a little conflit, yoavbls. Let's resolve it and give it another bump. TY! :-)

@yoavbls yoavbls force-pushed the allow-display-prop-in-spans-style branch from 91e8c53 to 6a26c24 Compare March 29, 2025 22:18
@yoavbls yoavbls changed the title Allow display prop on spans style Allow display:inline-block on spans style Mar 29, 2025
@yoavbls
Copy link
Author

yoavbls commented Mar 29, 2025

@mbtools updated, now allowing only inline-block to make it even safer

@mbtools
Copy link

mbtools commented Mar 29, 2025

LGTM 👍

@alanmoyano
Copy link

👀👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.