-
Notifications
You must be signed in to change notification settings - Fork 33.3k
Allow display:inline-block on spans style #180498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pinging @mjbvz who might have an opinion about this change. |
@mjbvz Hey Matt, |
This oneliner fixes the only missing feature of ts-pretty-errors. Could someone take a look? Looks like one year should have been enough time for reviewing this simple fix. |
Hello @mjbvz and @gjsjohnmurray. It has been nearly 1.5 years since this PR was opened. Are there any further reservations about merging this in? This enables a fix for #180496, which will enable a massive developer experience improvement for the Pretty TS Errors plugin. What are the steps we can take to get this prioritized and possibly merged? This would enable a huge improvement to the DX for nearly one million developer using this plugin. |
Any chance of merging this PR @mjbvz ? |
Hello! @mjbvz could you please check this out? This would be awesome for empowering extension developers. |
There's now a little conflit, yoavbls. Let's resolve it and give it another bump. TY! :-) |
91e8c53
to
6a26c24
Compare
@mbtools updated, now allowing only inline-block to make it even safer |
LGTM 👍 |
👀👀 |
Solves #180496