Fix monaco-edit color picker not working inside shadow dom (195606)

[mak1A4]

Added an additional check in the mousemove event to fix _onMouseLeave triggering when Monaco Editor is inside a Shadow DOM. Previously, _onMouseLeave would trigger even if the mouse was still inside the editor, due to event retargeting to the web component itself. This check resolves the issue with the color picker always closing.

Issue Link: #195606

[aiday-mar]

Hi there is an error in the CI that says:

[tsec-compile-check      ] src/vs/editor/browser/controller/mouseHandler.ts(108,66): error TS2345: Argument of type 'EventTarget | null' is not assignable to parameter of type 'Node | null'.
[tsec-compile-check      ]   Type 'EventTarget' is missing the following properties from type 'Node': baseURI, childNodes, firstChild, isConnected, and 43 more.
[tsec-compile-check      ] src/vs/editor/browser/controller/mouseHandler.ts(108,89): error TS2339: Property 'host' does not exist on type 'Node'.

[mak1A4]

Hi : ) I made some changes and the type errors should be solved now

[DevMammadov]

Hi there, monaco devs did not reviwed PR yet, i am facing this issue how can i solve it for now ? @mak1A4

[mak1A4]

Hi there, monaco devs did not reviwed PR yet, i am facing this issue how can i solve it for now ? @mak1A4

I can only tell you how I fixed it for now, I'm using the esm version of monaco-editor and I just patched the File /vs/editor/browser/controller/mouseHandler.ts inside node_modules. In my case esbuild will then use the patched file instead of upstream for building. I use patch-package to apply the patch automatically on postinstall.

[aiday-mar]

Hey @hediet, it appears the author of this PR would like a review from the person responsible for developing the monaco-editor.

[aiday-mar]

I am currently not able to review and verify this PR because the monaco editor has to adopt some ESM changes first. Currently when I compile the code and run the monaco editor playground from VS Code I see the following:

This PR will be deferred until this other issue is fixed.