fix(git): filter out fork username when checking out branch #208514
+55
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
feature/git-extension-checkout-branch-filter-out-usernames
branch
from
d214b56 to
3834b82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: GitHub PRs have a copy button for their head branch. If it's a fork, it contains the username as a prefix, e.g.
username:branchname. This PR will filter the first part out. (:as a character is not allowed as a branch name).This required me to introduce a new proposed API to the QuickPick element, allowing it to use a regular expression pattern to filter its items. Implementing a callback based approach like it was already implemented on the actual widget seems not great, due to the async nature of the extension host -> main process communication.
Whats the best way of covering it with tests?
Thats the button:
Fixes #201012