Add optional "showPreview" to WorkspaceEditMetadata to allow forcing preview without needsConfirmation changes #210175
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preview without needsConfirmation changes bulkEditService.apply already supported a showPreview flag in its options, but there was no way to provide it when calling `applyEdit`. This adds a new flag to `WorkspaceEditMetadata` that will be passed along. Fixes microsoft#207578 by allowing preview without needsConfirmation Also see microsoft#200991
vcalescu
suggested changes
Oct 7, 2024
|
Hi! I made a suggestion to change one line, just for a bit more clarity. Please let me know how I can help with the docs here, whether it's writing or reviewing. |
Co-authored-by: Veronica Calescu <vcalescu@kx.com>
|
This feature would be super useful! Will it make it into a release soon? |
|
Any update on getting this feature released? I'm also looking to use this for an extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bulkEditService.applyalready supported ashowPreviewflag in its options, but there was no way to provide it when callingapplyEdit. This adds a new flag toWorkspaceEditMetadatathat will be passed along.needsConfirmationneedsConfirmationresults in all checkboxes unchecked #200991I couldn't find automated tests that verify whether the preview was triggered - if someone can point me at these and give some pointers on how best to test, I will happily add them. Thanks!