Skip to content

Added files.simpleDialog.currentDirectory option #225565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Added files.simpleDialog.currentDirectory option #225565

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
446a7f7
Added files.simpleDialog.currentDirectory option
babakfp Aug 14, 2024
705ee16
Renamed to files.dialog.currentDirectory
babakfp Aug 14, 2024
fc33f8d
Better option description and placement order
babakfp Aug 14, 2024
e7c40fb
Merge branch 'main' into simple-dialog-current-directory
alexr00 Dec 10, 2024
03ed474
Merge branch 'microsoft:main' into simple-dialog-current-directory
babakfp Dec 10, 2024
53fe387
Merge branch 'microsoft:main' into simple-dialog-current-directory
babakfp Dec 10, 2024
8262afa
use `openFolderStartLocation` only with paths that are directories
babakfp Dec 10, 2024
53d684f
Update src/vs/workbench/contrib/files/browser/files.contribution.ts
babakfp Dec 13, 2024
65b8751
Merge branch 'main' into simple-dialog-current-directory
alexr00 Dec 17, 2024
20913a8
Check setting before doing stat
alexr00 Dec 17, 2024
a82bf25
Address feedback
alexr00 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/vs/workbench/contrib/files/browser/files.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,11 @@ configurationRegistry.registerConfiguration({
'description': nls.localize('files.simpleDialog.enable', "Enables the simple file dialog for opening and saving files and folders. The simple file dialog replaces the system file dialog when enabled."),
'default': false
},
'files.simpleDialog.currentDirectory': {
'type': 'boolean',
'description': nls.localize('files.simpleDialog.currentDirectory', "Open the current directory instead of the parent directory when enabled."),
'default': false
},
'files.participants.timeout': {
type: 'number',
default: 60000,
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/services/dialogs/browser/abstractFileDialogService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export abstract class AbstractFileDialogService implements IFileDialogService {
return this.preferredHome(schemeFilter);
}

return resources.dirname(candidate);
return this.configurationService.getValue('files.simpleDialog.currentDirectory') ? candidate : resources.dirname(candidate);
}

async preferredHome(schemeFilter = this.getSchemeFilterForWindow()): Promise<URI> {
Expand Down