Skip to content

Add debug/watch/context to list of valid menu extension points #237751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

adrianstephens
Copy link
Contributor

This is a fix for #237750 - it just adds debug/watch/context to the list of valid menu extension points, which I presume was accidentally missed.

@gjsjohnmurray
Copy link
Contributor

Does the title of this PR need correcting?

Copy link

@sanqro sanqro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adrianstephens adrianstephens changed the title debug/variables/context Add debug/variables/context to list of valid menu extension points Jan 13, 2025
@adrianstephens adrianstephens changed the title Add debug/variables/context to list of valid menu extension points Add debug/watch/context to list of valid menu extension points Jan 14, 2025
@connor4312
Copy link
Member

Yea this should be fine, we already have similar menu extension points for other places variables/expressions are shown

@connor4312 connor4312 enabled auto-merge (squash) March 2, 2025 19:24
connor4312
connor4312 previously approved these changes Mar 2, 2025
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did anybody try this?

image

The hard part about this is what the toolbar context should be. We need to define a new object which is safe to serialize and has a reasonable shape, and then that object is basically API

DonJayamanne
DonJayamanne previously approved these changes Mar 3, 2025
auto-merge was automatically disabled March 13, 2025 21:34

Head branch was pushed to by a user without write access

@adrianstephens adrianstephens dismissed stale reviews from DonJayamanne and connor4312 via 2976886 March 13, 2025 21:34
@adrianstephens
Copy link
Contributor Author

adrianstephens commented Mar 13, 2025

I had a stab at the watch view context. In the interests of doing the least harm I added a toJSON to the Expression class which serializes it to the same thing the Variables view does - basically a session id and a DAP Variable. The Variables view seems to work around the same problem by using a global variable 'variableInternalContext'. I like my idea better!

While I was in there, I moved the data breakpoint commands to debugCommands.ts, and added them to the Watch view.

@thegecko
Copy link
Contributor

Does this duplicate #212501

@adrianstephens
Copy link
Contributor Author

@thegecko - huh; it looks like it does - although I'm only trying to bring the Watch panel to parity with Variables. Sorry I didn't notice yours.
Do you want to review mine and/or add to it? Do you have any insight into why yours went no further, or how we can prevent that happening to this one?

@roblourens roblourens modified the milestones: March 2025, April 2025 Mar 25, 2025
@roblourens roblourens removed this from the April 2025 milestone Apr 29, 2025
@roblourens roblourens added this to the May 2025 milestone Apr 29, 2025
@adrianstephens
Copy link
Contributor Author

@roblourens is there any realistic chance of you looking at this, or should I abandon it?

@roblourens roblourens modified the milestones: May 2025, June 2025 Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants