-
Notifications
You must be signed in to change notification settings - Fork 33.3k
Add debug/watch/context to list of valid menu extension points #237751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add debug/watch/context to list of valid menu extension points #237751
Conversation
Does the title of this PR need correcting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Yea this should be fine, we already have similar menu extension points for other places variables/expressions are shown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Head branch was pushed to by a user without write access
2976886
I had a stab at the watch view context. In the interests of doing the least harm I added a toJSON to the Expression class which serializes it to the same thing the Variables view does - basically a session id and a DAP Variable. The Variables view seems to work around the same problem by using a global variable 'variableInternalContext'. I like my idea better! While I was in there, I moved the data breakpoint commands to debugCommands.ts, and added them to the Watch view. |
Does this duplicate #212501 |
@thegecko - huh; it looks like it does - although I'm only trying to bring the Watch panel to parity with Variables. Sorry I didn't notice yours. |
@roblourens is there any realistic chance of you looking at this, or should I abandon it? |
This is a fix for #237750 - it just adds debug/watch/context to the list of valid menu extension points, which I presume was accidentally missed.