Skip to content

Add kitty external terminal support for macOS #239473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stefan-sedlak
Copy link

Implemented issue: #239470

Implementation includes:

  • Detecting the presence of a running Kitty instance via its socket.
  • Providing commands like "send-text" and "select-window" via the existing external terminal service or a new dedicated Kitty terminal service.
  • Leveraging waiting loop to ensure the terminal socket is available before attempting to execute commands.
  • Proper error messages when Kitty is not installed or fails to launch.

Existing test cases (related to macOS external terminal) are passing
No additional tests were added.

@stefan-sedlak
Copy link
Author

@microsoft-github-policy-service agree

@stefan-sedlak
Copy link
Author

Hi @meganrogge , @Tyriar ,
could you pease have a look on the commit and check if it requires changes?
Thx

Copy link

@Fobnud-8wokpo-qivsyz Fobnud-8wokpo-qivsyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo

@ZeckWork
Copy link

Up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants