Skip to content

Fix bracket snippet overwriting chars outside the closing bracket #240604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix bracket snippet overwriting chars outside the closing bracket #240604

wants to merge 1 commit into from
+4 −2

Conversation

RedCMD
Copy link
Contributor

@RedCMD RedCMD commented Feb 13, 2025

Fixes #235515

if the prefix == the surrounding text
then endColumn was already capturing the closing bracket

@RedCMD RedCMD mentioned this pull request Feb 13, 2025
Open
@hediet hediet assigned jrieken and unassigned hediet Feb 13, 2025
@RedCMD
Copy link
Contributor Author

RedCMD commented Apr 18, 2025

@jrieken would you mind reviewing this thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brackets Snippet deleting chars
3 participants
@RedCMD @jrieken @hediet