fix merging snippets #243255
Open
fix merging snippets #243255
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superle3
force-pushed
the
nested-tabstops-fix
branch
from
a4e5805 to
e1bd7c7
Compare
|
any update on this? |
|
@jrieken |
superle3
force-pushed
the
nested-tabstops-fix
branch
2 times, most recently
from
eca170a to
7fa7674
Compare
|
@microsoft-github-policy-service agree |
superle3
force-pushed
the
nested-tabstops-fix
branch
from
7fa7674 to
d3e3310
Compare
|
Also fixed the floating point issue. broken_vscode_snippetsv2.mp4After: fixed_vscode_snippetsv2.mp4The testing snippets are just to show the problem, without anything distracting. I think the floating point problem is from #87226. |
increase nesting level of the snippet based on how many snippets need to be merged instead an arbitrary value of 10 and reorder the indexes afterwards to avoid floating point problems where nestinglevel< 1e-15 would be added upon index > 1, where the index then wouldn't change.
superle3
force-pushed
the
nested-tabstops-fix
branch
from
d3e3310 to
c84c37c
Compare
|
@jrieken any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increase nesting level of the snippet based on how many snippets need to be merged instead an arbitrary value of 10.
Fixes #230149 and whatever duplicate it is of.
This doesn't adress the floating point issue that arises when more then 14 snippets are expanded.
Currentlty it is not possible to make a snippet for a 4x4 matrix in latex which uses atleast 16 tabstops, exceeding the 10 tabstop limit.