Make Monaco Editor compatible with Vite #249962
Open
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monaco Editor uses some static properties that reference the class they are defined in. This is equivalent to `this`. Monaco Editor also uses decorators. TypeScript compiles this in a way that works (with some small boilerplate code). In Vite however, this compiles to broken code. This change replaces self-references via in static properties via their identifier with `this`. The changes were cherry-picked from microsoft#249616.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monaco Editor uses some static properties that reference the class they are defined in. This is equivalent to
this. Monaco Editor also uses decorators. TypeScript compiles this in a way that works (with some small boilerplate code). In Vite however, this compiles to broken code.This change replaces self-references via in static properties via their identifier with
this.The changes were cherry-picked from #249616.