-
Notifications
You must be signed in to change notification settings - Fork 33.3k
support resource completions for Git Bash
#251120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do: ![]() |
lramos15
previously approved these changes
Jun 10, 2025
meganrogge
commented
Jun 10, 2025
meganrogge
commented
Jun 10, 2025
meganrogge
commented
Jun 10, 2025
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionService.ts
Outdated
Show resolved
Hide resolved
…nalCompletionService.ts
meganrogge
commented
Jun 10, 2025
roblourens
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #248559
This pull request introduces support for handling Git Bash paths in the terminal completion service for relative and absolute paths. Key changes include the addition of path conversion utilities, updates to the terminal completion logic, and new test cases for Git Bash path handling and completions.
We convert from git bash style path to window style path to resolve the folders/files on the filesystem and convert to git bash style paths for labels of the completion items, providing the file system path as a detail.