Skip to content

support resource completions for Git Bash #251120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 10, 2025
Merged

support resource completions for Git Bash #251120

merged 11 commits into from
Jun 10, 2025

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jun 10, 2025

fixes #248559

This pull request introduces support for handling Git Bash paths in the terminal completion service for relative and absolute paths. Key changes include the addition of path conversion utilities, updates to the terminal completion logic, and new test cases for Git Bash path handling and completions.

We convert from git bash style path to window style path to resolve the folders/files on the filesystem and convert to git bash style paths for labels of the completion items, providing the file system path as a detail.

{2CADF100-5829-4EE9-9FF8-59E87EB78C31}

@meganrogge
Copy link
Contributor Author

meganrogge commented Jun 10, 2025

To do:
Why don't I get completions when typing / after cd ? Works when I manually request them though. EDIT this reproduces on Insider's / has always been an issue, tracking here #251128.

{5EF7E491-8D12-4961-884B-0B5A9117E98A}

lramos15
lramos15 previously approved these changes Jun 10, 2025
@meganrogge meganrogge enabled auto-merge (squash) June 10, 2025 18:34
@meganrogge meganrogge requested a review from Tyriar June 10, 2025 18:34
@meganrogge meganrogge merged commit 23f0f36 into main Jun 10, 2025
8 checks passed
@meganrogge meganrogge deleted the merogge/git-bash-2 branch June 10, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource completions use wrong path separator for git bash
3 participants