Fix accessibility label for Copilot model picker dropdown #251138
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Copilot model picker dropdown in inline chat (Ctrl+I) was not providing adequate accessibility labels for screen reader users. Previously, the dropdown only announced "Pick Model - {model_name}" which didn't clearly communicate the purpose of the control.
Changes Made
setAriaLabelAttributes
method that provides a descriptive label: "Select language model, currently {model_name}"Before vs After
Before: Screen readers announced "Pick Model - GPT-4"
After: Screen readers announce "Select language model, currently GPT-4"
Technical Details
setAriaLabelAttributes
inModelPickerActionItem
classlocalize()
function for internationalization supportThe fix ensures compliance with WCAG 4.1.2 (Name, Role, Value) by providing clear, descriptive labels that help screen reader users understand both the control's purpose and current state.
Fixes #250598.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either: