Skip to content

Move shell integration ps1 into module #251303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 14, 2025
Merged

Move shell integration ps1 into module #251303

merged 8 commits into from
Jun 14, 2025

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 12, 2025

Fixes #250000

@Tyriar Tyriar added this to the June 2025 milestone Jun 12, 2025
@Tyriar Tyriar requested a review from anthonykim1 June 12, 2025 18:41
@Tyriar Tyriar self-assigned this Jun 12, 2025
@Tyriar Tyriar enabled auto-merge June 12, 2025 18:42
@anthonykim1 anthonykim1 marked this pull request as draft June 13, 2025 22:09
auto-merge was automatically disabled June 13, 2025 22:09

Pull request was converted to draft

@anthonykim1
Copy link
Contributor

anthonykim1 commented Jun 13, 2025

Still seem fine (testing on Mac pwsh with starship, and Windows parallels pwsh 7.4.0.)

Screenshot 2025-06-13 at 4 07 19 PM

and

Screenshot 2025-06-13 at 5 55 46 PM

@Tyriar Tyriar marked this pull request as ready for review June 14, 2025 16:33
@Tyriar Tyriar enabled auto-merge June 14, 2025 16:33
@Tyriar Tyriar merged commit dd48c7f into main Jun 14, 2025
8 checks passed
@Tyriar Tyriar deleted the tyriar/250000 branch June 14, 2025 17:37
Tyriar added a commit that referenced this pull request Jun 18, 2025
This reverts commit dd48c7f, reversing
changes made to 80f28ae.
Tyriar added a commit that referenced this pull request Jun 18, 2025
Revert "Merge pull request #251303 from microsoft/tyriar/250000"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shellIntegration.ps1 Leaks Variables To Global Scope
3 participants