Skip to content

Move shell integration ps1 into module #251303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 14, 2025
Merged

Move shell integration ps1 into module #251303

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e717a6f
Move shell integration ps1 into module
Tyriar Jun 12, 2025
af72ade
Ensure psm1 is included in packages
Tyriar Jun 12, 2025
88678d8
Fix path test
Tyriar Jun 12, 2025
6afed85
Use Import-Module instead of dot sourcing in terminalEnvironment.test.ts
anthonykim1 Jun 13, 2025
0389649
Use Import-Module also when process.platform !== win32
anthonykim1 Jun 13, 2025
acecc75
Change extension to be .psm1 in terminalEnvironment.test.ts
anthonykim1 Jun 13, 2025
7761fdf
Codesign pwsh modules
Tyriar Jun 14, 2025
3962d9c
Compile build folder
Tyriar Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/platform/terminal/test/node/terminalEnvironment.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ suite('platform - terminalEnvironment', async () => {
// These tests are only expected to work on Windows 10 build 18309 and above
(getWindowsBuildNumber() < 18309 ? suite.skip : suite)('pwsh', async () => {
const expectedPs1 = process.platform === 'win32'
? `try { . "${repoRoot}\\out\\vs\\workbench\\contrib\\terminal\\common\\scripts\\shellIntegration.ps1" } catch {}`
? `try { Import-Module "${repoRoot}\\out\\vs\\workbench\\contrib\\terminal\\common\\scripts\\shellIntegration.ps1" } catch {}`
: `. "${repoRoot}/out/vs/workbench/contrib/terminal/common/scripts/shellIntegration.ps1"`;
suite('should override args', async () => {
const enabledExpectedResult = Object.freeze<IShellIntegrationConfigInjection>({
Expand Down
Loading