Add light mode support to GitHub authentication sign-in page #251509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
TylerLeonhardt
June 15, 2025 00:55
TylerLeonhardt
approved these changes
Jun 16, 2025
DonJayamanne
approved these changes
Jun 16, 2025
Subham-KRLX
pushed a commit
to Subham-KRLX/vscode
that referenced
this pull request
Jun 17, 2025
…ft#251509) * Initial plan for issue * Add light mode support to GitHub auth page using CSS media queries Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com> * use vscode colors --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com> Co-authored-by: Tyler Leonhardt <tyleonha@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds light mode support to the GitHub authentication sign-in page based on the user's browser preference, using CSS media queries.
Changes Made
@media (prefers-color-scheme: light)media query toextensions/github-authentication/media/auth.css#ffffff(white)#1e1e1e(dark gray)#1e1e1e(dark gray for visibility)#d73a4a(GitHub standard error red)Implementation Details
Browser Support
The
prefers-color-schememedia query is supported by all modern browsers and gracefully falls back to the existing dark mode in older browsers that don't support it.Before/After
Dark mode (default): Dark background (#2C2C32) with white text
Light mode (new): White background with dark text, automatically applied when user has light mode preference
Fixes #251508.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.