Skip to content

Remove redundant "Successfully signed out" notification #251512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 15, 2025

This PR removes the redundant "Successfully signed out" notification that appears when users sign out from an account in VS Code.

Problem

When users sign out from an account, VS Code shows a toast notification saying "Successfully signed out." However, this notification is redundant because:

  • The Account view already provides visual feedback through UI changes (badges, sign-in prompts)
  • Users can see their signed-out status in the Account view immediately
  • The notification adds unnecessary noise to the user experience

Successfully signed out notification

Solution

Removed the single line of code that triggers the notification in the MainThreadAuthenticationProvider.removeSession() method:

// Before
async removeSession(sessionId: string): Promise<void> {
    await this._proxy.$removeSession(this.id, sessionId);
    this.notificationService.info(nls.localize('signedOut', "Successfully signed out."));
}

// After  
async removeSession(sessionId: string): Promise<void> {
    await this._proxy.$removeSession(this.id, sessionId);
}

Impact

  • Users will no longer see the redundant toast notification when signing out
  • The Account view continues to provide all necessary visual feedback about authentication status
  • Core authentication functionality remains unchanged
  • No breaking changes to the authentication API

Fixes #233400.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • electronjs.org
    • Triggering command: node-gyp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Is "Sucessfully signed out" notification really needed Remove redundant "Successfully signed out" notification Jun 15, 2025
@Copilot Copilot AI requested a review from TylerLeonhardt June 15, 2025 01:30
Copilot finished work on behalf of TylerLeonhardt June 15, 2025 01:30
@TylerLeonhardt TylerLeonhardt marked this pull request as ready for review June 15, 2025 01:42
@TylerLeonhardt TylerLeonhardt enabled auto-merge (squash) June 15, 2025 01:42
@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 15, 2025
bpasero
bpasero previously approved these changes Jun 15, 2025
@TylerLeonhardt
Copy link
Member

Fix this error:

[tsec-compile-check ] src/vs/workbench/api/browser/mainThreadAuthentication.ts(56,20): error TS6138: Property 'notificationService' is declared but its value is never read.

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jun 16, 2025

Fix this error:

[tsec-compile-check ] src/vs/workbench/api/browser/mainThreadAuthentication.ts(56,20): error TS6138: Property 'notificationService' is declared but its value is never read.

Fixed in commit e6564c9. Removed the unused notificationService parameter from the MainThreadAuthenticationProvider constructor and updated the instantiation accordingly.

Copilot finished work on behalf of TylerLeonhardt June 16, 2025 06:11
@TylerLeonhardt TylerLeonhardt merged commit 6b2375b into main Jun 16, 2025
8 checks passed
@TylerLeonhardt TylerLeonhardt deleted the copilot/fix-233400 branch June 16, 2025 22:29
Subham-KRLX pushed a commit to Subham-KRLX/vscode that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Error loading sessions

Retrying...

Successfully merging this pull request may close these issues.

Is "Sucessfully signed out" notification really needed
5 participants