Fix failure of revealing webview with viewColumn which does not exist #87832
+26
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vigilans
changed the title
Vigilans
force-pushed
the
vigilans/fix-webview-reveal
branch
from
8191d3f to
4e444a1
Compare
Vigilans
force-pushed
the
vigilans/fix-webview-reveal
branch
from
4e444a1 to
a8ef4b4
Compare
mjbvz
reviewed
Jan 7, 2020
| @@ -869,6 +869,8 @@ export class DelegatingEditorService implements IEditorService { | |||
|
|
|||
| createInput(input: IResourceEditor): IEditorInput { return this.editorService.createInput(input); } | |||
|
|
|||
| findTargetGroup(input: IEditorInput, options?: IEditorOptions, group?: OpenInEditorGroup): IEditorGroup { return this.editorService.findTargetGroup(input, options, group); } | |||
There was a problem hiding this comment.
@bpasero Can you please take a look at how this change exposes findTargetGroup. Is there a better way to accomplish this?
|
@mjbvz how is |
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
create a webviewandreveal a webview's behavior is not consistent, when aviewColumnoption is provided, but that column(group) does not exist:SIDE_GROUPwill open the webview on the active group's sideSIDE_GROUPwill do nothing (revealed on the webview's current group)The root cause of such inconsistency is in that
createWebviewforward the viewColumn(group) information toeditorService.openEditor, which will be handled byeditorService.findTargetGroup.However,
revealWebviewgets hands dirty to find the target group by itself, and some important logic is missing, e.g. handling ofSIDE_GROUP. So when passingviewColumnto be 1 (start from 0) when there's only 1 column, it will be revealed to column 0 instead of 1.This PR makes
editorService.findTargetGrouppublic, and foward the group number to it to reuse its logic, and keep the behavior ofrevealingandcreatingconsistent.This PR fixes #71608.