8361529: GenShen: Fix bad assert in swap card tables

[earthling-amzn]

Clean backport. Fixes bad pointer in assert.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361529: GenShen: Fix bad assert in swap card tables (Bug - P3)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26228/head:pull/26228
$ git checkout pull/26228

Update a local copy of the PR:
$ git checkout pull/26228
$ git pull https://git.openjdk.org/jdk.git pull/26228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26228

View PR using the GUI difftool:
$ git pr show -t 26228

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26228.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361529: GenShen: Fix bad assert in swap card tables

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the jdk25 branch:

• 9adc480: 8361447: [REDO] Checked version of JNI ReleaseArrayElements needs to filter out known wrapped arrays

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk25 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@earthling-amzn The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (abf285a2)
• 00: Full (889f5af1)

[kevinrushforth]

If the priority of this bug (I see that the issue type is Task, which seems wrong) is correct, then this doesn't meet the criteria for backporting to JDK 25 during RDP1. See JEP 3.

[earthling-amzn]

Yes, the ticket should have been marked a bug, thank you for fixing that. This change to the assert really should have been made with the same commit where we fixed an issue it uncovered (#26246). We can leave the assertion change out, but it's also low risk (only affects Shenandoah debug builds).

[kevinrushforth]

If this is objectively a P3, then you could raise the priority. Otherwise, maybe consider backporting it to jdk25u?

[kevinrushforth]

If this is objectively a P3, then you could raise the priority

Since, as you pointed out, this is a follow-on to the other fix, raising the priority seems OK to me.

[shipilev]

There are test failures, I assume they are fixed by #26246? Integrate that one first and confirm there are no failures then? (I think you can technically update the openjdk-bots:backport-earthling-amzn-1de2acea-jdk25 branch, since you probably are a collaborator on that repo, but I have never actually tried.)

[shipilev]

Looks fine for JDK 25.

[earthling-amzn]

/integrate

[openjdk]

Going to push as commit 20fc8f7.
Since your change was applied there have been 6 commits pushed to the jdk25 branch:

• dd82a09: 8350177: C2 SuperWord: Integer.numberOfLeadingZeros, numberOfTrailingZeros, reverse and bitCount have input types wrongly truncated for byte and short
• 9f21845: 8360775: Fix Shenandoah GC test failures when APX is enabled
• c5d0f1b: 8360776: Disable Intel APX by default and enable it with -XX:+UnlockExperimentalVMOptions -XX:+UseAPX in all builds
• ... and 3 more: https://git.openjdk.org/jdk/compare/4d5211ccb0dce13eeef9b7f12d014dd58957c854...jdk25

Your commit was automatically rebased without conflicts.

[openjdk]

@earthling-amzn Pushed as commit 20fc8f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.