-
Notifications
You must be signed in to change notification settings - Fork 522
8359387: Bump minimum JDK version for JavaFX to JDK 23 #1827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@kevinrushforth |
@kevinrushforth an approved CSR request is already required for this pull request. |
jfx.jdk.target.version=22 | ||
jfx.build.jdk.version.min=23 | ||
jfx.build.jdk.buildnum.min=37 | ||
jfx.jdk.target.version=23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gradle 8.5 does not support JDK23 so jfx.gradle.version.min should be updated to 8.10.2
ref: https://docs.gradle.org/8.10.2/release-notes.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds all went fine.
Thanks for the reviews. I'll file the CSR, but let it sit for a while to also give others a chance to review or reply to the thread on the openjfx-dev mailing list. I will also need to merge master some time after #1832 is integrated, since there will be a (trivial) merge conflict for me to resolve. |
/integrate |
Going to push as commit 6029e3e. |
@kevinrushforth Pushed as commit 6029e3e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR bumps the minimum version of the JDK needed to run JavaFX to JDK 23.
In order for JavaFX to be able to use more recent JDK features, we should increase the minimum version of the JDK that can run the latest JavaFX. Additionally, there is an ongoing cost to keeping JavaFX buildable and runnable on older versions of Java, and little reason to continue to do so.
This continues our recent practice of setting the minimum JDK for JavaFX N to JDK N-2. JavaFX N is primarily intended for use with JDK N and we also build and test it against JDK N-1 (which is typically what we use as the boot JDK). Anything older than that, including the proposed minimum JDK N-2 (23 in this specific case), is untested.
This PR targeted to JavaFX 25, and must not be backported to any earlier version. This needs a CSR and a release note.
/reviewers 2
/csr
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1827/head:pull/1827
$ git checkout pull/1827
Update a local copy of the PR:
$ git checkout pull/1827
$ git pull https://git.openjdk.org/jfx.git pull/1827/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1827
View PR using the GUI difftool:
$ git pr show -t 1827
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1827.diff
Using Webrev
Link to Webrev Comment