Skip to content

8359387: Bump minimum JDK version for JavaFX to JDK 23 #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jun 13, 2025

This PR bumps the minimum version of the JDK needed to run JavaFX to JDK 23.

In order for JavaFX to be able to use more recent JDK features, we should increase the minimum version of the JDK that can run the latest JavaFX. Additionally, there is an ongoing cost to keeping JavaFX buildable and runnable on older versions of Java, and little reason to continue to do so.

This continues our recent practice of setting the minimum JDK for JavaFX N to JDK N-2. JavaFX N is primarily intended for use with JDK N and we also build and test it against JDK N-1 (which is typically what we use as the boot JDK). Anything older than that, including the proposed minimum JDK N-2 (23 in this specific case), is untested.

This PR targeted to JavaFX 25, and must not be backported to any earlier version. This needs a CSR and a release note.

/reviewers 2
/csr


Progress

  • Change requires CSR request JDK-8359467 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

  • JDK-8359387: Bump minimum JDK version for JavaFX to JDK 23 (Enhancement - P3)
  • JDK-8359467: Bump minimum JDK version for JavaFX to JDK 23 (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1827/head:pull/1827
$ git checkout pull/1827

Update a local copy of the PR:
$ git checkout pull/1827
$ git pull https://git.openjdk.org/jfx.git pull/1827/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1827

View PR using the GUI difftool:
$ git pr show -t 1827

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1827.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2025

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 13, 2025

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359387: Bump minimum JDK version for JavaFX to JDK 23

Reviewed-by: arapte, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the csr Need approved CSR to integrate pull request label Jun 13, 2025
@openjdk
Copy link

openjdk bot commented Jun 13, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk
Copy link

openjdk bot commented Jun 13, 2025

@kevinrushforth an approved CSR request is already required for this pull request.

jfx.jdk.target.version=22
jfx.build.jdk.version.min=23
jfx.build.jdk.buildnum.min=37
jfx.jdk.target.version=23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradle 8.5 does not support JDK23 so jfx.gradle.version.min should be updated to 8.10.2
ref: https://docs.gradle.org/8.10.2/release-notes.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks.

@kevinrushforth kevinrushforth marked this pull request as ready for review June 17, 2025 15:47
@kevinrushforth kevinrushforth requested a review from arapte June 17, 2025 15:47
@kevinrushforth
Copy link
Member Author

Reviewers: @arapte @johanvos @tiainen

@openjdk openjdk bot added the rfr Ready for review label Jun 17, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2025

Webrevs

Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds all went fine.

@kevinrushforth
Copy link
Member Author

Thanks for the reviews. I'll file the CSR, but let it sit for a while to also give others a chance to review or reply to the thread on the openjfx-dev mailing list.

I will also need to merge master some time after #1832 is integrated, since there will be a (trivial) merge conflict for me to resolve.

@kevinrushforth kevinrushforth requested review from tiainen and arapte July 8, 2025 20:35
@kevinrushforth
Copy link
Member Author

I will also need to merge master some time after #1832 is integrated, since there will be a (trivial) merge conflict for me to resolve.

This is now merged. The trivial conflict was in the surrounding context, not the diffs themselves.

@tiainen @arapte Can you re-review?

@openjdk openjdk bot added ready Ready to be integrated and removed csr Need approved CSR to integrate pull request labels Jul 9, 2025
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 9, 2025

Going to push as commit 6029e3e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 9, 2025
@openjdk openjdk bot closed this Jul 9, 2025
@openjdk openjdk bot removed the ready Ready to be integrated label Jul 9, 2025
@openjdk openjdk bot removed the rfr Ready for review label Jul 9, 2025
@openjdk
Copy link

openjdk bot commented Jul 9, 2025

@kevinrushforth Pushed as commit 6029e3e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants