Skip to content

[enterprise-4.14] OSDOCS-15164 [NETOBSERV] Add IPsec to 4.14 #95598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Jul 3, 2025

https://issues.redhat.com/browse/OSDOCS-15164

Was mistakenly removed from cherry-pick #95571 to 4.14

Original PR: #95552

Version(s):
4.14

Issue:
https://issues.redhat.com/browse/OSDOCS-15164

Link to docs preview:

QE review:
QE is not required for this PR.

Additional information:

Note to self: When this PR is merged, the cp-4.14 PR for Rel Notes will need to be rebased so it picks up these changes, and hopefully stops throwing errors related to the contents of this PR.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 3, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 3, 2025

@gwynnemonahan gwynnemonahan changed the title [NETOBSERV] Add IPsec to 4.14 OSDOCS-15164 [NETOBSERV] Add IPsec to 4.14 Jul 3, 2025
@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 3, 2025
@gwynnemonahan gwynnemonahan changed the title OSDOCS-15164 [NETOBSERV] Add IPsec to 4.14 [enterprise-4.14] OSDOCS-15164 [NETOBSERV] Add IPsec to 4.14 Jul 3, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments; PTAL
Overall looks good!

Gentle reminder to squash commits before adding the merge label

[id="network-observability-configuring-ipsec-with-flow-collector-resource_{context}"]
= Configuring IPsec with the FlowCollector custom resource

In {product-title}, IPsec is disabled by default. You can enable IPsec by following the instructions in "Configuring IPsec encryption".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In {product-title}, IPsec is disabled by default. You can enable IPsec by following the instructions in "Configuring IPsec encryption".
In {product-title}, IPsec is disabled by default, however, you can configure IPsec by using the `FlowCollector` custom resource (CR).

You can add about referring to the "Configuring IPsec encryption" section in the prereqs.


.Prerequisite

* You have enabled IPsec encryption on {product-title}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* You have enabled IPsec encryption on {product-title}.
* You have enabled IPsec encryption on {product-title}. To enable IPsec encryption on your cluster, see the "Configuring IPsec encryption" section.

. Select *cluster* then select the *YAML* tab.
. Configure the `FlowCollector` custom resource for IPsec:
+
.Example configuration of `FlowCollector` for IPsec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.Example configuration of `FlowCollector` for IPsec
.Example IPsec configuration in `FlowCollector`

@xenolinux xenolinux removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 7, 2025
@gwynnemonahan
Copy link
Contributor Author

gwynnemonahan commented Jul 7, 2025

Hey @xenolinux ,

Since this is a late cherry-pick for a release last week, and these changes would need to be applied to all the other OCP branches, which is outside the scope of this PR, these changes are being tracked here: https://issues.redhat.com/browse/OSDOCS-15173

@xenolinux
Copy link
Contributor

Hey @xenolinux ,

Since this is a late cherry-pick for a release last week, and these changes would need to be applied to all the other OCP branches, which is outside the scope of this PR, these changes are being tracked here: https://issues.redhat.com/browse/OSDOCS-15173

Okay. Merging the PR then

@xenolinux
Copy link
Contributor

@gwynnemonahan Can you squash commits?

@gwynnemonahan
Copy link
Contributor Author

Hey @xenolinux ,

Commits squashed. Checks are running. Thanks!

Copy link

openshift-ci bot commented Jul 7, 2025

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xenolinux xenolinux merged commit 566951a into openshift:enterprise-4.14 Jul 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants