-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[enterprise-4.14] OSDOCS-15164 [NETOBSERV] Add IPsec to 4.14 #95598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enterprise-4.14] OSDOCS-15164 [NETOBSERV] Add IPsec to 4.14 #95598
Conversation
729fb35
to
8d48e8c
Compare
🤖 Mon Jul 07 12:46:57 - Prow CI generated the docs preview: |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments; PTAL
Overall looks good!
Gentle reminder to squash commits before adding the merge label
modules/network-observability-proc_configuring-ipsec-with-flow-collector-resource.adoc
Show resolved
Hide resolved
[id="network-observability-configuring-ipsec-with-flow-collector-resource_{context}"] | ||
= Configuring IPsec with the FlowCollector custom resource | ||
|
||
In {product-title}, IPsec is disabled by default. You can enable IPsec by following the instructions in "Configuring IPsec encryption". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In {product-title}, IPsec is disabled by default. You can enable IPsec by following the instructions in "Configuring IPsec encryption". | |
In {product-title}, IPsec is disabled by default, however, you can configure IPsec by using the `FlowCollector` custom resource (CR). |
You can add about referring to the "Configuring IPsec encryption" section in the prereqs.
modules/network-observability-proc_configuring-ipsec-with-flow-collector-resource.adoc
Show resolved
Hide resolved
|
||
.Prerequisite | ||
|
||
* You have enabled IPsec encryption on {product-title}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* You have enabled IPsec encryption on {product-title}. | |
* You have enabled IPsec encryption on {product-title}. To enable IPsec encryption on your cluster, see the "Configuring IPsec encryption" section. |
modules/network-observability-proc_configuring-ipsec-with-flow-collector-resource.adoc
Show resolved
Hide resolved
. Select *cluster* then select the *YAML* tab. | ||
. Configure the `FlowCollector` custom resource for IPsec: | ||
+ | ||
.Example configuration of `FlowCollector` for IPsec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.Example configuration of `FlowCollector` for IPsec | |
.Example IPsec configuration in `FlowCollector` |
modules/network-observability-proc_configuring-ipsec-with-flow-collector-resource.adoc
Show resolved
Hide resolved
modules/network-observability-proc_configuring-ipsec-with-flow-collector-resource.adoc
Show resolved
Hide resolved
modules/network-observability-proc_configuring-ipsec-with-flow-collector-resource.adoc
Show resolved
Hide resolved
Hey @xenolinux , Since this is a late cherry-pick for a release last week, and these changes would need to be applied to all the other OCP branches, which is outside the scope of this PR, these changes are being tracked here: https://issues.redhat.com/browse/OSDOCS-15173 |
Okay. Merging the PR then |
@gwynnemonahan Can you squash commits? |
b6f69fb
to
97dc357
Compare
Hey @xenolinux , Commits squashed. Checks are running. Thanks! |
@gwynnemonahan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/OSDOCS-15164
Was mistakenly removed from cherry-pick #95571 to 4.14
Original PR: #95552
Version(s):
4.14
Issue:
https://issues.redhat.com/browse/OSDOCS-15164
Link to docs preview:
QE review:
QE is not required for this PR.
Additional information:
Note to self: When this PR is merged, the cp-4.14 PR for Rel Notes will need to be rebased so it picks up these changes, and hopefully stops throwing errors related to the contents of this PR.