Skip to content

fix: add optional chain to prevent nullish broken #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2025

Conversation

ShenQingchuan
Copy link
Contributor

@ShenQingchuan ShenQingchuan commented Jun 22, 2025

I have encountered this issue in my own PPT project (which can be a reproduction repo): https://github.com/ShenQingchuan/vue-vine-ppt-2025

image

But it'll be OK after restarting the slidev dev server.

I think it might be caused by my Vue Vine plugin using in setup/main.ts, maybe it's applied before Vue Router and the router instance was not initialized at that moment? I'm not quite sure ...

But I've tried and approved that this line of change works as expected, which is adding optional chain operators.

fix #2047

Copy link

netlify bot commented Jun 22, 2025

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit c2194a9
🔍 Latest deploy log https://app.netlify.com/projects/slidev/deploys/685775a1debed50008a376d2
😎 Deploy Preview https://deploy-preview-2208--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@kermanx kermanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be #2047

Copy link
Member

@kermanx kermanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be #2047

Copy link

pkg-pr-new bot commented Jun 22, 2025

Open in StackBlitz

@slidev/client

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/client@2208

create-slidev

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev@2208

create-slidev-theme

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@2208

@slidev/parser

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/parser@2208

@slidev/cli

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/cli@2208

@slidev/types

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/types@2208

commit: c2194a9

@kermanx kermanx merged commit af9fda3 into slidevjs:main Jun 22, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Router Injection Error with Additional Resolvers
2 participants