Toolkit package created for OIDC client #1
Conversation
|
@souravchanduka Are we covering telemetry in here ? Can you please add the details ? |
There was a problem hiding this comment.
Hi @souravchanduka! I think some logic could be simplified by using postJson from the HTTP Client
packages/core/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@actions/core", | |||
| "version": "1.4.0", | |||
| "version": "1.5.0", | |||
There was a problem hiding this comment.
I believe we are already on 1.5.0, so this might need to be updated in your main branch
There was a problem hiding this comment.
I can see 1.4.0 in main branch right now. If there is any PR with 1.5.0 version then should we wait for it to be merged before this PR? If yes, here version should be 1.5.1, right?
There was a problem hiding this comment.
Ha I had a PR open for it, but it hasn't gotten merged: actions#873
There was a problem hiding this comment.
Just a couple small things @souravchanduka and I think this one should be good to go!
packages/core/README.md
Outdated
|
|
||
| const audience = core.getInput('audience', {required: false}) | ||
| const id_token = await core.getIDToken(audience) | ||
| core.setOutput('id_token', id_token) |
There was a problem hiding this comment.
Is it good practice to set this as an output? I don't know, I think we should just be careful what we put as an example. @thboop @TingluoHuang
There was a problem hiding this comment.
I have removed the setOutput, instead have just put a comment saying it can further be used to fetch access token from any third party cloud providers. Does this make sense?
There was a problem hiding this comment.
Left a couple minor comments @souravchanduka. But otherwise looks good to me!
packages/core/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@actions/core", | |||
| "version": "1.4.0", | |||
| "version": "1.5.0", | |||
There was a problem hiding this comment.
Ha I had a PR open for it, but it hasn't gotten merged: actions#873
* Update release for core 1.5.0 * Update RELEASES.md * Run npm audit fix
…toolkit into main-oidc-client
In order to get the temporary credentials for accessing cloud resources, we need to get the ID Token from the action service. This ID Token will be used by login actions of different cloud providers. Since the code to fetch the ID Token will be same for all the login actions, we have decided to create a toolkit package for it. All the login actions would import this package and get the ID token for further use.