ci: upgrade go to 1.23 #18135
Draft
ci: upgrade go to 1.23 #18135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (16)
|
siddarthkay
force-pushed
the
ci-bump-go-123
branch
from
5894f5f to
18e5bb6
Compare
siddarthkay
force-pushed
the
ci-bump-go-123
branch
from
18e5bb6 to
9c7c09d
Compare
jakubgs
approved these changes
Jun 16, 2025
|
Please also update the BUILDING.md file |
apentori
approved these changes
Jun 19, 2025
siddarthkay
force-pushed
the
ci-bump-go-123
branch
from
9c7c09d to
c219f30
Compare
siddarthkay
force-pushed
the
ci-bump-go-123
branch
from
c219f30 to
5662706
Compare
siddarthkay
commented
Jul 8, 2025
| @@ -8,7 +8,7 @@ pipeline { | |||
| agent { | |||
| docker { | |||
| label 'linux' | |||
| image 'statusteam/nim-status-client-build:1.6.6-qt5.15.2' | |||
| image 'statusteam/nim-status-client-build:1.6.7-qt5.15.2' | |||
There was a problem hiding this comment.
hmm we should use the qt6 image here
caybro
reviewed
Jul 8, 2025
|
|
||
| > ⚠️ Note: 1.22 version is a strict requirement for now. Version 1.23 won't work | ||
| > ⚠️ Note: 1.23 version is a strict requirement for now. Version 1.24 won't work |
There was a problem hiding this comment.
With this PR, I was able to build against 1.24 as well... :)
There was a problem hiding this comment.
~/git/status/status-desktop (17764-improper-lightdark-mode*$%|u=)$ go version
go version go1.24.4 linux/amd64
Default for Fedora; otherwise I wouldn't be able to build at all
caybro
reviewed
Jul 8, 2025
| @@ -127,7 +127,7 @@ Install [Homebrew](https://brew.sh/) if not already installed. | |||
| #### Install Required Packages | |||
|
|
|||
| ```bash | |||
| brew install cmake pkg-config go@1.22 qt@5 jq nvm yarn protobuf | |||
| brew install cmake pkg-config go@1.23 qt@5 jq nvm yarn protobuf | |||
There was a problem hiding this comment.
Suggested change
| brew install cmake pkg-config go@1.23 qt@5 jq nvm yarn protobuf | |
| brew install cmake pkg-config go@1.23 qt@6 jq nvm yarn protobuf |
There was a problem hiding this comment.
I think this is just not rebased.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary