-
Notifications
You must be signed in to change notification settings - Fork 18
update view definition #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wcag3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wcag3-howtos canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as a first step and sensible improvement from current draft definition. We can use this to build on for further refining what a view is and whether it is called that or something else.
I like this, too. The deleted part is extra information that could go in a note or understanding document to provide more context for specific environments, such as native mobile. |
I thought we'd not do the naming in this PR? view-unit seems unintuitive and unusual to me, would like to see more support in the group for it before we adopt it. |
ok if it's just a working term that works for me |
I disagree. If we have a term that has many comments against it (even though we all love the concept) I think we should EITHER embrace new terms until someone as something against it other than "it feels weird or different". OR we should do somthing like use view/view-unit to show alternate terms for everyone to be looking at when doing critiques. and to see which ones actually work best. also -- we should not be redefining a common term like view to mean something other than common usage (like we are) so we should be looking for another term anyway. best |
Objection, for a term to “seem unintuitive and unusual” (the feedback I gave), are two serious qualifications that you just dismiss. It's helpful for a term to be intuitive and usual. I take your feedback seriously, please consider mine too. I'll expand in our GH discussion. For now, yes I agree it's fine to use this working term. |
sorry, I meant no disrespect. I was just stating an opposing view to your comment "I thought we'd not do the naming in this PR? view-unit seems unintuitive and unusual to me, would like to see more support in the group for it before we adopt it." Best |
I'm in support of this, also. Thanks for putting this together, @stevefaulkner. |
I agree that we need a definition for change of context. I submit that it is problematic for the definition to explicitly include the conditional phrasing about disorienting the user. There are major changes of context which are not problematic. The WCAG 2 definition works okay (in the context of WCAG 2) but for WCAG 3 it would be helpful to distinguish between changes of context which are predictable (and those that are not) and not even hint that every change of context is an accessibility issue. |
@@ -1427,6 +1427,22 @@ <h2>Glossary</h2> | |||
experience. [=Semi-automated evaluation=] allows machines to guide humans | |||
to areas that need inspection. The emerging field of testing conducted via | |||
machine learning is not included in this definition.</p></dd> | |||
<dt data-status="developing"><dfn data-lt="Change of context">Change of context</dfn></dt> | |||
<dd><p>Major change in the <a>content</a> of the <a>view-unit</a> that, if made without user awareness, can disorient users who are not able to perceive the entire <a>view</a simultaneously</p></dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<dd><p>Major change in the <a>content</a> of the <a>view-unit</a> that, if made without user awareness, can disorient users who are not able to perceive the entire <a>view</a simultaneously</p></dd> | |
<dd><p>Major change in the <a>content</a> of the <a>view-unit</a> that, if made without user awareness, can disorient users who are not able to perceive the entire <a>view</a> simultaneously</p></dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should ”view” (alone, in the context of this definition) have the anchor tags? That is, are we to have a definition for ”view” separate from the “view-unit” term. Or should <a>view</a>
also be <a>view-unit</a>
?
</dd> | ||
<dd> | ||
<div class="ednote"> | ||
<p>A change of content is not always a change of context. Changes in content, such as an expanding outline, dynamic menu, opening a non-modal dialog, or a tab control do not necessarily change the context.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>A change of content is not always a change of context. Changes in content, such as an expanding outline, dynamic menu, opening a non-modal dialog, or a tab control do not necessarily change the context.</p> | |
<p>A change of content is not always a change of context. Changes in content — such as an expanding outline, dynamic menu, opening a non-modal dialog, or a tab control — do not necessarily change the context.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the em-dash treatment better than commas, but since this PR includes examples as a the very next sentence — might we drop the em-dash clause entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I think it is useful in reading the sentence. But I would put it in parentheses
A change of content is not always a change of context. Changes in content (e.g an expanding outline, dynamic menu, opening a non-modal dialog, or a tab control) do not necessarily change the context.
Uh oh!
There was an error while loading. Please reload this page.