Add type hints to aioftp

[honglei]

Since the aioftp requires Python3.7+ right now, type hints may benefit the project.

[pohmelie]

How will they benefit the project? 🤔

[honglei]

@pohmelie https://realpython.com/python-type-checking/#pros-and-cons

[honglei]

https://fastapi.tiangolo.com/release-notes/#highlights
https://python.plainenglish.io/how-to-use-the-new-and-cool-annotated-typing-feature-of-fastapi-4a2fdc48ef74

[pohmelie]

Ok, aioftp already have good docs with types in docstrings, aioftp do not use pydantic. If you have time to do PR I will review it and merge.

[honglei]

@pohmelie PR #165

[9en9i]

Are there any updates? Is there anything I can do to help?

[pohmelie]

It looks like #165 is stuck a little. So it is up to you to make new pr.

[9en9i]

Okay, I'm on it. Is the target version of Python now 3.8? Previously as I see in the pr it was 3.11

[pohmelie]

Yep, I set to 3.11 before, but forget about old versions life cycle. So right now it is 3.8+.

[9en9i]

Hi, working on a pull request with added typing is nearing completion, but I've run into some issues. First I would like to know if a comparison of type analyzer tools has been done? I saw that mypy was discussed in a past pull request, is it still the choice? Or maybe there is an option to use pyright? My main type analyzer tool at work is pyright, so I decided to simplify things a bit and use a more familiar tool to start with. So, I used it to fix (actually most of it, the rest needs discussion because it goes beyond just type checking and I didn't dare touch it without discussion) all the typing errors and turned on mypy, assuming that there might be some minor differences that could be fixed. But I encountered missing functionality in mypy. I'm talking about this use case, which pyright implemented a few years ago: microsoft/pyright#2737.
Because of the lack of possibility to use Literal with overload decorator mypy mistakenly finds about a hundred errors (maybe a little less). In my experience pyright is a more advanced analyzer because of faster implementation of features and as a consequence wider support.

Regarding mypy, I also think in this case I can fix the code using the protocol.

[pohmelie]

@9en9i

First I would like to know if a comparison of type analyzer tools has been done?

IDK which is better, but for me mypy is 99% ok. I'm using it in some projects. You can use any type checker you want, since there are no type linters right now.

[9en9i]

@pohmelie Hi, is there any information somewhere about what you need to run to run the tests?

[9en9i]

I mean I get a timeout error when running tests.

[pohmelie]

There are no «special» requirements for tests. You can check instructions in github workflows (ci-cd.yml file). But it is just a pip install -e ./[dev] and pytest.

[9en9i]

Yeah, that's what I did. But I get an error on test 45
FAILED tests/test_connection.py::test_pasv_connection_pasv_forced_response_address[127.0.0.1] - TimeoutError