fix: vibrancy window border

[clavin]

Description of Change

Chromium sets some properties on NSWindow when we initialize a widget with support for translucency (added in #46392). This causes undesirable visual effects, such as the loss of the window border (see #46586).

The easiest fix is to patch out the unintended Chromium code. We set both properties ourselves when appropriate.

Fixes #46586
Ref: #46392

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant API documentation, tutorials, and examples are updated and follow the documentation style guide
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed the border style of windows with vibrancy on macOS.

[clavin]

Worth mentioning there's an alternate solution using WidgetDelegate::OnWidgetInitialized to undo what is done by the Chromium code in this patch. It would let us avoid the patch, but we'd still have an invisible "dependency" on this Chromium code and the result would be a lot less clean.

[codebytere]

@clavin personally i'd rather the non-patch route with appropriate commenting - our patches have been ballooning lately and there's no clear path for removal here. We can also try to talk to upstream about it.

[clavin]

Refactored this to use WidgetDelegate::OnWidgetInitialized as suggested by @codebytere. I think there may be a reasonable way to upstream this too, but I don't have the bandwidth atm to do it.

[release-clerk]

Release Notes Persisted

Fixed the border style of windows with vibrancy on macOS.

[trop]

I have automatically backported this PR to "36-x-y", please check out #46771

[trop]

I have automatically backported this PR to "35-x-y", please check out #46772