Updated Game Object renderer blocks to use 'this'.

Split out the Graphics renderer to avoid being a giant if/else loop.

Author: photonstorm

.eslintrc.json

@@ -40,7 +40,7 @@
         "consistent-this": [ "error", "_this" ],
         "eol-last": [ "error" ],
         "func-call-spacing": [ "error", "never" ],
-        "indent": [ "error", 4, { "SwitchCase": 4 } ],
+        "indent": [ "error", 4, { "SwitchCase": 1 } ],
         "key-spacing": [ "error", { "beforeColon": false, "afterColon": true }],
         "linebreak-style": [ "off" ],
         "lines-around-comment": [ "error", { "beforeBlockComment": true }],

src/renderer/canvas/CanvasRenderer.js

@@ -181,7 +181,6 @@ Phaser.Renderer.Canvas.prototype = {
 
         //  Add Pre-render hook
 
-        // this.renderSession.currentBlendMode = 0;
         // this.renderSession.shakeX = this.game.camera._shake.x;
         // this.renderSession.shakeY = this.game.camera._shake.y;
 

src/renderer/canvas/gameobjects/Container.js

@@ -1,33 +1,30 @@
 /**
-* Renders the object using the Canvas renderer
-*
-* @method _renderCanvas
-* @param renderSession {RenderSession} 
-* @private
+* Note that 'this' in all functions here refer to the owning object.
+* For example the Group, Stage, Sprite, etc. because the render function
+* here is mapped to the prototype for the game object.
 */
 Phaser.Renderer.Canvas.GameObjects.Container = {
 
-    render: function (renderer, source)
+    render: function (renderer)
     {
-        if (source.visible === false || source.alpha === 0)
+        if (this.visible === false || this.alpha === 0)
         {
             return;
         }
 
-        // if (this._cacheAsBitmap)
-        // {
-        //     this._renderCachedSprite(renderSession);
-        //     return;
-        // }
+        if (this._cacheAsBitmap)
+        {
+            return this.renderCachedSprite(renderer);
+        }
 
-        if (source._mask)
+        if (this._mask)
         {
-            renderer.pushMask(source._mask);
+            renderer.pushMask(this._mask);
         }
 
-        for (var i = 0; i < source.children.length; i++)
+        for (var i = 0; i < this.children.length; i++)
         {
-            var child = source.children[i];
+            var child = this.children[i];
 
             child.render(renderer, child);
         }
@@ -39,11 +36,10 @@ Phaser.Renderer.Canvas.GameObjects.Container = {
 
     },
 
-    renderCache: function (renderer, source)
+    renderCachedSprite: function (renderer)
     {
-        //  Do something
-
-        return source;
+        //  TODO
+        return renderer;
     }
 
 };