-
Notifications
You must be signed in to change notification settings - Fork 184
feat(step-generation, app): emit distribute_with_liquid_class for python #18603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.5.0 #18603 +/- ##
==========================================================
- Coverage 25.88% 23.74% -2.14%
==========================================================
Files 3279 3233 -46
Lines 284277 279751 -4526
Branches 28648 28095 -553
==========================================================
- Hits 73579 66440 -7139
- Misses 210671 213284 +2613
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
"x": 0, | ||
"y": 0, | ||
"z": 0, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might have to update your test after I checked in the change to generate more compact code. (This line would probably be something like "offset": {"x": 0, "y": 0, "z": 0},
`# ${upperCase(stepArgs?.commandCreatorFnName)} STEP\n\n` + | ||
nonLoadCommands + | ||
`\n` + | ||
finalDropTipCommand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So after this change, the drop tip will always be handled by transfer/consolidate/distribute_with_liquid_class()
now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct! since QT does not support mix()
closes AUTH-1099
Overview
This PR introduces
distribute_with_liquid_class
in distribute compound command in step-generationTest Plan and Hands on Testing
Review code and test creating a distribute step and uploading to the app. should pass analysis
Changelog
getCustomLiquidClassProperties
to account for the distribute argsdisposalVolume
andconditioningVolume
distribute_with_liquid_class
indistribute
Risk assessment
low, behind ff