Skip to content

fix(shared-data): use correct stacking offsets for tipracks #18621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

ahiuchingau
Copy link
Contributor

@ahiuchingau ahiuchingau commented Jun 12, 2025

Overview

Update tiprack stacking overlap offsets to improve stacker movements. Bumping the labware version to increase robustness!

I don't think this warrants a labware version bump because:
1. Stacking of tipracks is not currently supported without a stacker
2. The only instrument to interact with the lid is the gripper, and 0.25 mm changes in z in would not have a huge effect on protocols.

@ahiuchingau ahiuchingau requested a review from a team as a code owner June 12, 2025 22:29
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 23.66%. Comparing base (0793522) to head (bfbbaf2).
Report is 25 commits behind head on edge.

Files with missing lines Patch % Lines
...p/src/organisms/ODD/QuickTransferFlow/constants.ts 0.00% 18 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18621      +/-   ##
==========================================
+ Coverage   23.37%   23.66%   +0.28%     
==========================================
  Files        3238     3241       +3     
  Lines      279429   280214     +785     
  Branches    28096    28525     +429     
==========================================
+ Hits        65328    66303     +975     
+ Misses     214074   213884     -190     
  Partials       27       27              
Flag Coverage Δ
protocol-designer 19.10% <0.00%> (+0.04%) ⬆️
step-generation 4.85% <0.00%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...p/src/organisms/ODD/QuickTransferFlow/constants.ts 0.00% <0.00%> (ø)

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i agree

@ahiuchingau ahiuchingau force-pushed the fix_tiprack-stacking-offsets branch from 6d14459 to 9770a25 Compare June 13, 2025 18:46
@ahiuchingau ahiuchingau requested a review from a team as a code owner June 13, 2025 18:46
@ahiuchingau ahiuchingau requested a review from a team as a code owner June 16, 2025 16:59
@ahiuchingau ahiuchingau requested review from ncdiehl11 and removed request for a team June 16, 2025 16:59
@ahiuchingau ahiuchingau merged commit 1bbba0e into edge Jun 16, 2025
69 of 70 checks passed
@ahiuchingau ahiuchingau deleted the fix_tiprack-stacking-offsets branch June 16, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants