Skip to content

fix(api): Ensure Configure Nozzle Layout and Configure For Volume commands publish notifications #18631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

CaseyBatten
Copy link
Contributor

@CaseyBatten CaseyBatten commented Jun 13, 2025

Overview

Related to debugging work on RQA-4267

It seems we missed adding publishers for Configure Nozzle Layout and Configure For Volume. This made debugging and figuring out what kind of partial tip setup the pipette was actually in while going through logs a royal pain in the neck. Whoopsies!

Test Plan and Hands on Testing

  • Run the following protocol on a robot, should see commands published in the api logs for configure_nozzle_layout and configure_for_volume
from opentrons.protocol_api import ProtocolContext, SINGLE

metadata = {
    "protocolName": "Publisher test",
    "author": "Opentrons <protocols@opentrons.com>",
}
requirements = {
    "robotType": "Flex",
    "apiLevel": "2.23",
}

def run(protocol: ProtocolContext) -> None:
    tiprack = protocol.load_labware(load_name="opentrons_flex_96_tiprack_200ul", location="B2")
    p1000= protocol.load_instrument("flex_96channel_1000", mount="left", liquid_presence_detection=True)

    p1000.configure_nozzle_layout(style=SINGLE, start="A1", tip_racks=[tiprack])
    p1000.configure_for_volume(10)

    p1000.pick_up_tip()
    p1000.drop_tip()

Changelog

  • Added publish command for configure_nozzle_layout containing the instrument, style, start and end nozzles
  • Added publish command for configure_for_volume containing the instrument and the volume

Review requests

We're missing a few more of these, like on detect_liquid_presence, require_liquid_presence and measure_liquid_height as well. Thats on instrument context, we could be missing others on protocol context and module context. Should I scrape around and add other missing ones? This PR was originally just to help to debug an ongoing RQA ticket, but could be for general sustaining work as well.

Risk assessment

Low, just adding some missing publishers.

@CaseyBatten CaseyBatten requested a review from a team as a code owner June 13, 2025 20:33
@CaseyBatten CaseyBatten requested review from ddcc4 and removed request for a team June 13, 2025 20:34
@CaseyBatten CaseyBatten added the gen-analyses-snapshot-pr Generate a healing PR if the analyses snapshot test fails label Jun 13, 2025
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.53%. Comparing base (d3ce351) to head (a37c655).
Report is 15 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #18631   +/-   ##
=======================================
  Coverage   24.53%   24.53%           
=======================================
  Files        3236     3236           
  Lines      279292   279292           
  Branches    28079    28079           
=======================================
  Hits        68530    68530           
  Misses     210734   210734           
  Partials       28       28           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

A PR has been opened to address analyses snapshot changes. Please review the changes here: #18633

…ed snapshots (#18633)

This PR was requested on the PR
#18631

Co-authored-by: CaseyBatten <48519493+CaseyBatten@users.noreply.github.com>
@CaseyBatten CaseyBatten requested a review from a team as a code owner June 16, 2025 13:58
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, ty!

@CaseyBatten CaseyBatten merged commit d2bfb32 into edge Jun 16, 2025
30 of 31 checks passed
@CaseyBatten CaseyBatten deleted the fix_configure_nozzle_not_published branch June 16, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gen-analyses-snapshot-pr Generate a healing PR if the analyses snapshot test fails
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants